Skip to content

Sync eng/common directory with azure-sdk-tools for PR 9229 #8152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azure-sdk merged 2 commits into from
Oct 22, 2024
Merged

Sync eng/common directory with azure-sdk-tools for PR 9229 #8152

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf86ddf
Remove default sub config sub-config-azure-cloud-test-resources
weshaggard Oct 22, 2024
ff91afa
Fix quoting
weshaggard Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove default sub config sub-config-azure-cloud-test-resources 
We no longer want to default the configuration and instead
default from the service connection which had the info we need.
  • Loading branch information
@weshaggard @azure-sdk
weshaggard authored and azure-sdk committed Oct 22, 2024
commit bf86ddf150aa2e43e031b56813157a8aa012198b
2 changes: 1 addition & 1 deletion eng/common/TestResources/build-test-resource-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
parameters:
- name: SubscriptionConfiguration
type: string
default: $(sub-config-azure-cloud-test-resources)
default: {}
- name: SubscriptionConfigurations
type: object
default: null
Expand Down
3 changes: 1 addition & 2 deletions eng/common/TestResources/deploy-test-resources.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ parameters:
DeleteAfterHours: 8
Location: ''
EnvVars: {}
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources)
SubscriptionConfiguration: {}
ServiceConnection: not-specified
ResourceType: test
UseFederatedAuth: true
Expand Down Expand Up @@ -36,7 +36,6 @@ parameters:
# }
# }


steps:
- template: /eng/common/pipelines/templates/steps/cache-ps-modules.yml

Expand Down
2 changes: 1 addition & 1 deletion eng/common/TestResources/remove-test-resources.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

parameters:
ServiceDirectory: ''
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources)
SubscriptionConfiguration: $(SubscriptionConfiguration)
ServiceConnection: not-specified
ResourceType: test
EnvVars: {}
Expand Down