Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12734 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner October 31, 2025 21:49
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Oct 31, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the cspell package configuration to use a scoped package name and pin to an exact version. The changes standardize the package identity under the @azure-tools namespace and remove version flexibility by changing from a caret range to an exact version pin.

  • Renamed package from cspell-version-pin to @azure-tools/cspell
  • Marked the package as private
  • Changed cspell dependency from ^9.2.1 to exact version 9.2.1

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
eng/common/spelling/package.json Updated package name to scoped @azure-tools/cspell, added private flag, and pinned cspell to exact version 9.2.1
eng/common/spelling/package-lock.json Updated lockfile to reflect new package name and exact version dependency
Files not reviewed (1)
  • eng/common/spelling/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

{
"name": "cspell-version-pin",
"name": "@azure-tools/cspell",
"version": "1.0.0",
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version field in package-lock.json should be removed when the package is marked as private, as shown in package.json. Private packages typically don't need version tracking in the lockfile root.

Suggested change
"version": "1.0.0",

Copilot uses AI. Check for mistakes.
"": {
"name": "cspell-version-pin",
"version": "1.0.0",
"name": "@azure-tools/cspell",
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The packages root entry should include the 'private: true' field to match the package.json configuration and maintain consistency between the two files.

Suggested change
"name": "@azure-tools/cspell",
"name": "@azure-tools/cspell",
"private": true,

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants