-
Notifications
You must be signed in to change notification settings - Fork 347
Sync eng/common directory with azure-sdk-tools for PR 12734 #9352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the cspell package configuration to use a scoped package name and pin to an exact version. The changes standardize the package identity under the @azure-tools namespace and remove version flexibility by changing from a caret range to an exact version pin.
- Renamed package from
cspell-version-pinto@azure-tools/cspell - Marked the package as private
- Changed cspell dependency from
^9.2.1to exact version9.2.1
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/common/spelling/package.json | Updated package name to scoped @azure-tools/cspell, added private flag, and pinned cspell to exact version 9.2.1 |
| eng/common/spelling/package-lock.json | Updated lockfile to reflect new package name and exact version dependency |
Files not reviewed (1)
- eng/common/spelling/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "name": "cspell-version-pin", | ||
| "name": "@azure-tools/cspell", | ||
| "version": "1.0.0", |
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version field in package-lock.json should be removed when the package is marked as private, as shown in package.json. Private packages typically don't need version tracking in the lockfile root.
| "version": "1.0.0", |
| "": { | ||
| "name": "cspell-version-pin", | ||
| "version": "1.0.0", | ||
| "name": "@azure-tools/cspell", |
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The packages root entry should include the 'private: true' field to match the package.json configuration and maintain consistency between the two files.
| "name": "@azure-tools/cspell", | |
| "name": "@azure-tools/cspell", | |
| "private": true, |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12734 See eng/common workflow