Add structured logging support to custom log states #3005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks good. I will check at other data sources and confirm. |
We ignore these `Aggregate`, `Result` and `Metric` logs and don't log it anywhere. We rely the on formatted message to ignore these logs (one example here https://github.com/Azure/azure-functions-host/blob/b42df4d4e63ab87f7a737f5a65dadf3eb7ba7de4/src/WebJobs.Script/Diagnostics/FileLogger.cs#L50). Setting the formatter to `null` so that we still ignore these.
Updated format string.
Updated formatting.
Fixing UTs
Member
|
Hi @CodeBlanch , I have made some changes based on our last conversation. Also updated formatting to align with rest of the logs. If you are ok with these changes, I will merge the code and create a release. |
Contributor
Author
|
@RohitRanjanMS Changes LGTM! |
RohitRanjanMS
approved these changes
Aug 21, 2023
Member
|
This got merged on August 21st, so it looks like it should be in 3.0.38 or higher, but none are yet published to https://www.nuget.org/packages/Microsoft.Azure.WebJobs/ |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the LogMetric, LogFunctionResult, LogFunctionResultAggregate ILogger extensions to use TStates which support structured logging:
{OriginalFormat}attribute is added as the last KVP which contains a template for these logs.The reason for this is OpenTelemetry is implemented as an ILoggerProvider and it kind of barfs on the existing states which do not implement the typical structured logging state contract. Implementing this structure will make these logs work better with OpenTelemetry and likely many other ILoggerProvider implementations. See: Azure/azure-sdk-for-net#37832
This is similar to: dotnet/aspnetcore#45253