Skip to content
This repository was archived by the owner on Jul 26, 2024. It is now read-only.

fix aks secret name #248

Merged
arnaudlh merged 1 commit into from
Aug 26, 2021
Merged

fix aks secret name #248

arnaudlh merged 1 commit into from
Aug 26, 2021

Conversation

@jorseng
Copy link
Contributor

@jorseng jorseng commented Aug 26, 2021

Issue-id

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@jorseng jorseng added the bug Something isn't working label Aug 26, 2021
@jorseng jorseng requested a review from hieunhums August 26, 2021 08:45
@jorseng jorseng self-assigned this Aug 26, 2021
@arnaudlh arnaudlh added this to the 2108 milestone Aug 26, 2021
hieunhums
hieunhums approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@hieunhums hieunhums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh merged commit 0f5eca2 into master Aug 26, 2021
@arnaudlh arnaudlh deleted the fix-kustomization-secret branch August 26, 2021 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@hieunhums hieunhums hieunhums approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jorseng jorseng

Labels

bug Something isn't working

Projects

None yet

Milestone

2108

Development

Successfully merging this pull request may close these issues.

4 participants

@jorseng @hieunhums @arnaudlh