Skip to content
This repository was archived by the owner on Jul 26, 2024. It is now read-only.

Conversation

@bobalong79
Copy link

ACR entries are stored as azure_container_registries in the state file. This PR corrects the attribute name so that an ACR declared in a remote lz can be used.

e.g.

{
  "outputs":{
    "objects":{
      "value":{
        "lz_key":{
          "azure_container_registries":{
            "acr1":{ ... }
          }
        }
      }
    }
  }
}

PR Checklist


  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

Try referencing an ACR declared in a remote lz, e.g. for role mapping

role_mapping = {
  built_in_role_mapping = {
    azure_container_registries = {
      acr1 = {
        lz_key = "remote_lz"
        "AcrPull" = {
          aks_clusters = {
            keys = ["cluster_re1"]
          }
        }
      }
    }
  }
}

ACR entries are stored as "azure_container_registries" in the state file

e.g.
{
  "outputs":{
    "objects":{
      "value":{
        "lz_key":{
          "azure_container_registries":{
            "acr1":{ ... }
          }
        }
      }
    }
  }
}
@arnaudlh arnaudlh changed the base branch from master to patch.5.4.4 October 20, 2021 09:52
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM

@arnaudlh arnaudlh added the bug Something isn't working label Nov 4, 2021
@arnaudlh arnaudlh added this to the 2111 milestone Nov 4, 2021
@arnaudlh arnaudlh merged commit a33dee2 into Azure:patch.5.4.4 Nov 4, 2021
@bobalong79 bobalong79 deleted the ccoe-180 branch March 10, 2022 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants