Skip to content

Dynamically download Az module #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2021
Merged

Dynamically download Az module #29

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46f5fd0
Dynamically download Az module
amit-avit Mar 9, 2021
6d832b6
Added UTs and fixed existing one
amit-avit Mar 10, 2021
f4cc5cb
Review comments
amit-avit Mar 11, 2021
50f4ea7
Fixed bug due to missing await
amit-avit Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed bug due to missing await
  • Loading branch information
@amit-avit
amit-avit authored Mar 17, 2021
commit 50f4ea769b4ff34f92d0909d28b08a4b4e652521
2 changes: 1 addition & 1 deletion lib/Utilities/ArchiveTools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class ArchiveTools {
$ProgressPreference = 'SilentlyContinue'
Expand-Archive -Path ${zipPath} -DestinationPath ${destination}
$ProgressPreference = $prevProgressPref`;
PowerShellToolRunner_1.default.init();
yield PowerShellToolRunner_1.default.init();
const exitCode = yield PowerShellToolRunner_1.default.executePowerShellScriptBlock(script);
if (exitCode != 0) {
throw new Error(`Extraction using Expand-Archive cmdlet failed from ${zipPath} to ${destination}`);
Expand Down
2 changes: 1 addition & 1 deletion src/Utilities/ArchiveTools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export class ArchiveTools {
$ProgressPreference = 'SilentlyContinue'
Expand-Archive -Path ${zipPath} -DestinationPath ${destination}
$ProgressPreference = $prevProgressPref`;
PowerShellToolRunner.init();
await PowerShellToolRunner.init();
const exitCode = await PowerShellToolRunner.executePowerShellScriptBlock(script);
if (exitCode != 0) {
throw new Error(`Extraction using Expand-Archive cmdlet failed from ${zipPath} to ${destination}`);
Expand Down