Skip to content

Refreshing Node.js supported versions #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Refreshing Node.js supported versions #786

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
773da9a
Fixes #756
aaronpowell Dec 5, 2023
8e955ae
Fixing tests
aaronpowell Dec 5, 2023
ba492c3
Merge branch 'main' into node20-support
Timothyw0 Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing tests
  • Loading branch information
@aaronpowell
aaronpowell committed Dec 5, 2023
commit 8e955aee9ab9a27e4d88cab03b2f35737d913bb8
62 changes: 37 additions & 25 deletions src/core/func-core-tools.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,45 +53,57 @@ describe("funcCoreTools", () => {
describe("isCoreToolsVersionCompatible()", () => {
it("should return true for compatible versions", () => {
expect(isCoreToolsVersionCompatible(4, 10)).toBe(false);
expect(isCoreToolsVersionCompatible(3, 10)).toBe(true);
expect(isCoreToolsVersionCompatible(3, 10)).toBe(false);
expect(isCoreToolsVersionCompatible(2, 10)).toBe(true);
expect(isCoreToolsVersionCompatible(3, 11)).toBe(true);
expect(isCoreToolsVersionCompatible(2, 11)).toBe(false);
expect(isCoreToolsVersionCompatible(3, 11)).toBe(false);
expect(isCoreToolsVersionCompatible(2, 11)).toBe(true);
expect(isCoreToolsVersionCompatible(4, 12)).toBe(false);
expect(isCoreToolsVersionCompatible(3, 12)).toBe(true);
expect(isCoreToolsVersionCompatible(2, 12)).toBe(false);
expect(isCoreToolsVersionCompatible(3, 13)).toBe(true);
expect(isCoreToolsVersionCompatible(4, 14)).toBe(true);
expect(isCoreToolsVersionCompatible(3, 12)).toBe(false);
expect(isCoreToolsVersionCompatible(2, 12)).toBe(true);
expect(isCoreToolsVersionCompatible(4, 13)).toBe(false);
expect(isCoreToolsVersionCompatible(3, 13)).toBe(false);
expect(isCoreToolsVersionCompatible(2, 13)).toBe(true);
expect(isCoreToolsVersionCompatible(4, 14)).toBe(false);
expect(isCoreToolsVersionCompatible(3, 14)).toBe(true);
expect(isCoreToolsVersionCompatible(2, 14)).toBe(false);
expect(isCoreToolsVersionCompatible(4, 15)).toBe(true);
expect(isCoreToolsVersionCompatible(3, 15)).toBe(false);
expect(isCoreToolsVersionCompatible(4, 16)).toBe(true);
expect(isCoreToolsVersionCompatible(3, 16)).toBe(false);
expect(isCoreToolsVersionCompatible(2, 14)).toBe(true);
expect(isCoreToolsVersionCompatible(4, 15)).toBe(false);
expect(isCoreToolsVersionCompatible(3, 15)).toBe(true);
expect(isCoreToolsVersionCompatible(4, 16)).toBe(false);
expect(isCoreToolsVersionCompatible(3, 16)).toBe(true);
expect(isCoreToolsVersionCompatible(2, 16)).toBe(false);
expect(isCoreToolsVersionCompatible(4, 17)).toBe(true);
expect(isCoreToolsVersionCompatible(3, 17)).toBe(false);
expect(isCoreToolsVersionCompatible(4, 17)).toBe(false);
expect(isCoreToolsVersionCompatible(3, 17)).toBe(true);
expect(isCoreToolsVersionCompatible(2, 17)).toBe(false);
expect(isCoreToolsVersionCompatible(4, 18)).toBe(true);
expect(isCoreToolsVersionCompatible(3, 18)).toBe(false);
expect(isCoreToolsVersionCompatible(3, 18)).toBe(true);
expect(isCoreToolsVersionCompatible(2, 18)).toBe(false);
expect(isCoreToolsVersionCompatible(4, 19)).toBe(true);
expect(isCoreToolsVersionCompatible(3, 19)).toBe(true);
expect(isCoreToolsVersionCompatible(2, 19)).toBe(false);
expect(isCoreToolsVersionCompatible(4, 20)).toBe(true);
expect(isCoreToolsVersionCompatible(3, 20)).toBe(true);
expect(isCoreToolsVersionCompatible(2, 20)).toBe(false);
});
});

describe("detectTargetCoreToolsVersion()", () => {
it("should return the latest valid version for each Node version", () => {
expect(detectTargetCoreToolsVersion(8)).toBe(2);
expect(detectTargetCoreToolsVersion(9)).toBe(2);
expect(detectTargetCoreToolsVersion(10)).toBe(3);
expect(detectTargetCoreToolsVersion(11)).toBe(3);
expect(detectTargetCoreToolsVersion(12)).toBe(3);
expect(detectTargetCoreToolsVersion(13)).toBe(3);
expect(detectTargetCoreToolsVersion(14)).toBe(4);
expect(detectTargetCoreToolsVersion(15)).toBe(4);
expect(detectTargetCoreToolsVersion(16)).toBe(4);
expect(detectTargetCoreToolsVersion(10)).toBe(2);
expect(detectTargetCoreToolsVersion(11)).toBe(2);
expect(detectTargetCoreToolsVersion(12)).toBe(2);
expect(detectTargetCoreToolsVersion(13)).toBe(2);
expect(detectTargetCoreToolsVersion(14)).toBe(3);
expect(detectTargetCoreToolsVersion(15)).toBe(3);
expect(detectTargetCoreToolsVersion(16)).toBe(3);
expect(detectTargetCoreToolsVersion(17)).toBe(3);
expect(detectTargetCoreToolsVersion(18)).toBe(4);
expect(detectTargetCoreToolsVersion(19)).toBe(4);
expect(detectTargetCoreToolsVersion(20)).toBe(4);
// Unsupported Node versions should always return the latest version
expect(detectTargetCoreToolsVersion(8)).toBe(4);
expect(detectTargetCoreToolsVersion(9)).toBe(4);
expect(detectTargetCoreToolsVersion(7)).toBe(4);
expect(detectTargetCoreToolsVersion(17)).toBe(4);
expect(detectTargetCoreToolsVersion(21)).toBe(4);
});
});

Expand Down