feat: sixDotOne #1115
Merged
feat: sixDotOne #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an automated 'pull_request' containing updates to the library templates stored in 'modules/archetypes/lib'. Please review the 'files changed' tab to review changes. Co-authored-by: github-actions <[email protected]> Co-authored-by: Matt White <[email protected]>
…tatic apps (#1061) <!-- markdownlint-disable first-line-h1 --> <!-- Thank you for submitting a Pull Request. Please fill out the template below.--> ## Overview/Summary Azure static web apps are currently spawned without a known pattern in Public DNS zones with different partition ids in their FQDN. We are now counting [1,2,3,4,5].azurestaticapps.net with a unknown rising number. Private DNS Zones are used for private Endpoints correspondingly (privatelink.[1,2,3,4,5].azurestaticapps.net.) and as of the CAF principals need to be known before deploying the first resources. There is no programmatic approach known to me. Feel free to adjust to your needs. Examples for module calls: ``` # Adds all at PR time available: default + 1-5 configure_connectivity_resources = { ... advanced = {} } # Adds only zones: default + 4 + 5 configure_connectivity_resources = { ... advanced = { custom_privatelink_azurestaticapps_partitionids = [4, 5] } } ``` ## This PR fixes/adds/changes/removes 1. Adds all currently existing private DNS zones per default, when 'azure_web_apps_static_sites' is set to true. 2. Adds possibility to manually define a list of partition ids wanted. (Prohibits a breaking change when Microsoft adds a new partitionid) ### Breaking Changes none ## Testing Evidence - I did a plan on our current infrastructure and had no changes (all five private DNS Zone currently deployed) - Also tested the default behavior when not setting the new variable ## As part of this Pull Request I have - [x] Checked for duplicate [Pull Requests](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/pulls) - [ ] Associated it with relevant [issues](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/issues), for tracking and closure. - [x] Ensured my code/branch is up-to-date with the latest changes in the `main` [branch](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/tree/main) - [ ] Performed testing and provided evidence. - [x] Updated relevant and associated documentation. --------- Co-authored-by: Matt White <[email protected]>
This was
linked to
issues
Aug 29, 2024
…network ids (#1107) #1106 Updated spoke_virtual_networks_for_dns to include the secure virtual network ids <!-- markdownlint-disable first-line-h1 --> <!-- Thank you for submitting a Pull Request. Please fill out the template below.--> ## Overview/Summary Replace this with a brief description of what this Pull Request fixes, changes, etc. ## This PR fixes/adds/changes/removes 1. *Replace me* 2. *Replace me* 3. *Replace me* ### Breaking Changes 1. *Replace me* 2. *Replace me* ## Testing Evidence Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate). ## As part of this Pull Request I have - [ ] Checked for duplicate [Pull Requests](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/pulls) - [ ] Associated it with relevant [issues](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/issues), for tracking and closure. - [ ] Ensured my code/branch is up-to-date with the latest changes in the `main` [branch](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/tree/main) - [ ] Performed testing and provided evidence. - [ ] Updated relevant and associated documentation.
Member
Author
|
/azp run unit |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run unit |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run e2e |
|
No pipelines are associated with this pull request. |
Member
Author
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Only the clean up failed... think we are gtg |
jaredfholgate
previously approved these changes
Sep 2, 2024
Member
jaredfholgate
left a comment
jaredfholgate
left a comment
There was a problem hiding this comment.
LGTM, just a couple of minor things.
Member
Author
|
/azp run unit |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes/adds/changes/removes
Latest policy refresh.
See https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/milestone/13
Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
mainbranch