Skip to content

Conversation

@LaurentLesle
Copy link
Contributor

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Fixes Race condition results in InternalServerError when deploying in vhub a firewall, an express route gateway, vhub peering and routing intent #1135 - Race condition results in InternalServerError when deploying in vhub a firewall, an express route gateway, vhub peering and routing intent
  2. Fixes Updating existing vnet dns_server with Azure firewall leads to azurerm_virtual_network error. #1136 - Updating existing vnet dns_server with Azure firewall leads to azurerm_virtual_network error.
  3. Replace me

Breaking Changes

none

Testing Evidence

module.alz_connectivity.azurerm_virtual_hub_routing_intent.virtual_wan["/subscriptions/000000/resourceGroups/rg-prod-network-vwan/providers/Microsoft.Network/virtualHubs/lz-cl-hub-southeastasia/lz-cl-routingintent-southeastasia"]: Still creating... [6m40s elapsed]
module.alz_connectivity.azurerm_virtual_hub_routing_intent.virtual_wan["/subscriptions/000000/resourceGroups/rg-prod-network-vwan/providers/Microsoft.Network/virtualHubs/lz-cl-hub-southeastasia/lz-cl-routingintent-southeastasia"]: Creation complete after 6m41s [id=/subscriptions/000000/resourceGroups/rg-prod-network-vwan/providers/Microsoft.Network/virtualHubs/lz-cl-hub-southeastasia/routingIntent/lz-cl-routingintent-southeastasia]

Apply complete! Resources: 178 added, 0 changed, 0 destroyed.

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@LaurentLesle
Copy link
Contributor Author

@matt-FFFFFF Any udpates?

@matt-FFFFFF matt-FFFFFF changed the base branch from main to release/Nov2024 November 13, 2024 09:59
@matt-FFFFFF matt-FFFFFF merged commit beb1933 into Azure:release/Nov2024 Nov 13, 2024
@matt-FFFFFF matt-FFFFFF mentioned this pull request Nov 13, 2024
5 tasks
matt-FFFFFF added a commit that referenced this pull request Nov 13, 2024
<!-- markdownlint-disable first-line-h1 -->

Azure Landing Zones policy refresh
https://github.com/Azure/Enterprise-Scale/releases/tag/2024-11-05

And other minor improvements:

## This PR fixes/adds/changes/removes

1. includes #1200
2. includes #1183
3. includes #1137
4. includes #1143
5. fixes #1171
6. fixes #1170
7. fixes #1185
8. fixes #1176



![image](https://github.com/user-attachments/assets/18f34c9f-29cd-4499-9cd1-de2c85c6c0db)


![image](https://github.com/user-attachments/assets/52eb0679-6a3f-4cf6-a6f7-a8cf9d67f5d4)



## Testing Evidence

Please provide any testing evidence to show that your Pull Request
works/fixes as described and planned (include screenshots, if
appropriate).

## As part of this Pull Request I have

- [ ] Checked for duplicate [Pull
Requests](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/pulls)
- [ ] Associated it with relevant
[issues](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/issues),
for tracking and closure.
- [ ] Ensured my code/branch is up-to-date with the latest changes in
the `main`
[branch](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/tree/main)
- [ ] Performed testing and provided evidence.
- [ ] Updated relevant and associated documentation.

---------

Co-authored-by: cae-pr-creator[bot] <126156663+cae-pr-creator[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: Jed Laundry <[email protected]>
Co-authored-by: lolorol <[email protected]>
Co-authored-by: Camilo Aguilar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants