Skip to content

Conversation

@cae-pr-creator
Copy link
Contributor

This is an automated 'pull_request' containing updates to the library templates stored in 'modules/archetypes/lib'.
Please review the 'files changed' tab to review changes.

@matt-FFFFFF matt-FFFFFF marked this pull request as ready for review February 27, 2025 09:27
@matt-FFFFFF matt-FFFFFF self-assigned this Feb 27, 2025
@matt-FFFFFF
Copy link
Member

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question

},
"groupNames": []
"groupNames": [],
"definitionVersion": ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this being empty cause any problems?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not today no. The module is pretty selective about what it uses from the json

@briantaylor87
Copy link

briantaylor87 commented Mar 4, 2025

@matt-FFFFFF, @jaredfholgate Is there an ETA on when this will be merged to main?

@matt-FFFFFF matt-FFFFFF merged commit d49527a into main Mar 7, 2025
9 checks passed
@matt-FFFFFF matt-FFFFFF deleted the patch-library-672 branch March 7, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants