-
Notifications
You must be signed in to change notification settings - Fork 642
ci: migrate to oidc #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: migrate to oidc #1262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR migrates various CI pipeline tasks to use OIDC-compatible Azure tasks and updates related configurations.
- Replaces several Bash and PowerShell tasks with AzureCLI and AzurePowerShell tasks across different pipeline templates.
- Updates GitHub workflow tokens and cron expression, along with bumping Ubuntu VM images for tests.
Reviewed Changes
| File | Description |
|---|---|
| tests/pipelines/templates/tests-backend.yml | Switches from Bash to AzureCLI with updated script inputs. |
| tests/pipelines/templates/tests-common.yml | Replaces GoTool/Bash steps with AzureCLI for Terraform environment setup. |
| .github/workflows/update-policy.yml | Updates cron schedule and migrates from tibdex/github-app-token to actions/create-github-app-token with revised parameter names. |
| tests/pipelines/templates/tests-strategy.yml | Changes from PowerShell to AzurePowerShell with added version specification. |
| tests/pipelines/templates/tests-loop.yml | Converts multiple Bash tasks to AzureCLI with additional environment parameters. |
| tests/pipelines/tests-e2e.yml, tests/pipelines/tests-unit.yml | Updates Ubuntu VM images to ubuntu-22.04. |
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/update-policy.yml:48
- [nitpick] The input parameter name 'app-id' differs from the previous 'app_id'. Please ensure this naming change is aligned with the expected parameters of actions/create-github-app-token@v1.
app-id: ${{ secrets.APP_ID }}
|
/azp run unit |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jaredfholgate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok at first glance.
See successful run
https://dev.azure.com/mscet/CAE-ALZ-Terraform/_build/results?buildId=9798&view=results