Skip to content

Conversation

@matt-FFFFFF
Copy link
Member

@matt-FFFFFF matt-FFFFFF commented Feb 27, 2025

@matt-FFFFFF matt-FFFFFF changed the title feat: migrate to oidc ci: migrate to oidc Feb 27, 2025
@matt-FFFFFF matt-FFFFFF requested a review from Copilot February 27, 2025 14:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR migrates various CI pipeline tasks to use OIDC-compatible Azure tasks and updates related configurations.

  • Replaces several Bash and PowerShell tasks with AzureCLI and AzurePowerShell tasks across different pipeline templates.
  • Updates GitHub workflow tokens and cron expression, along with bumping Ubuntu VM images for tests.

Reviewed Changes

File Description
tests/pipelines/templates/tests-backend.yml Switches from Bash to AzureCLI with updated script inputs.
tests/pipelines/templates/tests-common.yml Replaces GoTool/Bash steps with AzureCLI for Terraform environment setup.
.github/workflows/update-policy.yml Updates cron schedule and migrates from tibdex/github-app-token to actions/create-github-app-token with revised parameter names.
tests/pipelines/templates/tests-strategy.yml Changes from PowerShell to AzurePowerShell with added version specification.
tests/pipelines/templates/tests-loop.yml Converts multiple Bash tasks to AzureCLI with additional environment parameters.
tests/pipelines/tests-e2e.yml, tests/pipelines/tests-unit.yml Updates Ubuntu VM images to ubuntu-22.04.

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/update-policy.yml:48

  • [nitpick] The input parameter name 'app-id' differs from the previous 'app_id'. Please ensure this naming change is aligned with the expected parameters of actions/create-github-app-token@v1.
app-id: ${{ secrets.APP_ID }}

@matt-FFFFFF
Copy link
Member Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok at first glance.

@matt-FFFFFF matt-FFFFFF merged commit c6065ea into main Feb 27, 2025
13 checks passed
@matt-FFFFFF matt-FFFFFF deleted the ci/migrateToOidc branch February 27, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants