Skip to content

Connectivity: Add OpenAI and Databricks Private Link DNS #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-FFFFFF merged 3 commits into from
Jun 6, 2024
Merged

Connectivity: Add OpenAI and Databricks Private Link DNS #918

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed9318a
Add Databricks Private Link
nyanhp Mar 28, 2024
f62212b
Merge branch 'main' into feature/additionaldnszones
matt-FFFFFF May 15, 2024
5b9d06e
Merge branch 'main' into feature/additionaldnszones
matt-FFFFFF Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,7 @@ object({
azure_database_for_mariadb_server = optional(bool, true)
azure_database_for_mysql_server = optional(bool, true)
azure_database_for_postgresql_server = optional(bool, true)
azure_databricks = optional(bool, true)
azure_digital_twins = optional(bool, true)
azure_event_grid_domain = optional(bool, true)
azure_event_grid_topic = optional(bool, true)
Expand All @@ -552,6 +553,7 @@ object({
azure_media_services = optional(bool, true)
azure_migrate = optional(bool, true)
azure_monitor = optional(bool, true)
azure_openai_service = optional(bool, true)
azure_purview_account = optional(bool, true)
azure_purview_studio = optional(bool, true)
azure_relay_namespace = optional(bool, true)
Expand Down Expand Up @@ -1109,6 +1111,7 @@ The following resources are used by this module:
- [time_sleep.after_azurerm_policy_set_definition](https://registry.terraform.io/providers/hashicorp/time/latest/docs/resources/sleep) (resource)
- [time_sleep.after_azurerm_role_assignment](https://registry.terraform.io/providers/hashicorp/time/latest/docs/resources/sleep) (resource)
- [time_sleep.after_azurerm_role_definition](https://registry.terraform.io/providers/hashicorp/time/latest/docs/resources/sleep) (resource)
- [azapi_resource.user_msi](https://registry.terraform.io/providers/Azure/azapi/latest/docs/data-sources/resource) (data source)
- [azurerm_policy_definition.external_lookup](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/policy_definition) (data source)
- [azurerm_policy_set_definition.external_lookup](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/policy_set_definition) (data source)

Expand Down
2 changes: 2 additions & 0 deletions modules/connectivity/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,7 @@ object({
azure_database_for_mariadb_server = optional(bool, true)
azure_database_for_mysql_server = optional(bool, true)
azure_database_for_postgresql_server = optional(bool, true)
azure_databricks = optional(bool, true)
azure_digital_twins = optional(bool, true)
azure_event_grid_domain = optional(bool, true)
azure_event_grid_topic = optional(bool, true)
Expand All @@ -344,6 +345,7 @@ object({
azure_media_services = optional(bool, true)
azure_migrate = optional(bool, true)
azure_monitor = optional(bool, true)
azure_openai_service = optional(bool, true)
azure_purview_account = optional(bool, true)
azure_purview_studio = optional(bool, true)
azure_relay_namespace = optional(bool, true)
Expand Down
2 changes: 2 additions & 0 deletions modules/connectivity/locals.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1459,6 +1459,7 @@ locals {
azure_database_for_mariadb_server = ["privatelink.mariadb.database.azure.com"]
azure_database_for_mysql_server = ["privatelink.mysql.database.azure.com"]
azure_database_for_postgresql_server = ["privatelink.postgres.database.azure.com"]
azure_databricks = ["privatelink.azuredatabricks.net"]
azure_digital_twins = ["privatelink.digitaltwins.azure.net"]
azure_event_grid_domain = ["privatelink.eventgrid.azure.net"]
azure_event_grid_topic = ["privatelink.eventgrid.azure.net"]
Expand All @@ -1474,6 +1475,7 @@ locals {
azure_media_services = ["privatelink.media.azure.net"]
azure_migrate = ["privatelink.prod.migration.windowsazure.com"]
azure_monitor = ["privatelink.monitor.azure.com", "privatelink.oms.opinsights.azure.com", "privatelink.ods.opinsights.azure.com", "privatelink.agentsvc.azure-automation.net", "privatelink.blob.core.windows.net"]
azure_openai_service = ["privatelink.openai.azure.com"]
azure_purview_account = ["privatelink.purview.azure.com"]
azure_purview_studio = ["privatelink.purviewstudio.azure.com"]
azure_relay_namespace = ["privatelink.servicebus.windows.net"]
Expand Down
2 changes: 2 additions & 0 deletions modules/connectivity/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ variable "settings" {
azure_database_for_mariadb_server = optional(bool, true)
azure_database_for_mysql_server = optional(bool, true)
azure_database_for_postgresql_server = optional(bool, true)
azure_databricks = optional(bool, true)
azure_digital_twins = optional(bool, true)
azure_event_grid_domain = optional(bool, true)
azure_event_grid_topic = optional(bool, true)
Expand All @@ -267,6 +268,7 @@ variable "settings" {
azure_media_services = optional(bool, true)
azure_migrate = optional(bool, true)
azure_monitor = optional(bool, true)
azure_openai_service = optional(bool, true)
azure_purview_account = optional(bool, true)
azure_purview_studio = optional(bool, true)
azure_relay_namespace = optional(bool, true)
Expand Down
2 changes: 2 additions & 0 deletions tests/modules/settings/settings.connectivity.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,11 @@ locals {
azure_database_for_mariadb_server = false
azure_database_for_mysql_server = false
azure_database_for_postgresql_server = false
azure_databricks = false
azure_digital_twins = false
azure_key_vault_managed_hsm = false
azure_kubernetes_service_management = false
azure_openai_service = false
azure_purview_account = false
azure_purview_studio = false
azure_relay_namespace = false
Expand Down
2 changes: 2 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,7 @@ variable "configure_connectivity_resources" {
azure_database_for_mariadb_server = optional(bool, true)
azure_database_for_mysql_server = optional(bool, true)
azure_database_for_postgresql_server = optional(bool, true)
azure_databricks = optional(bool, true)
azure_digital_twins = optional(bool, true)
azure_event_grid_domain = optional(bool, true)
azure_event_grid_topic = optional(bool, true)
Expand All @@ -380,6 +381,7 @@ variable "configure_connectivity_resources" {
azure_media_services = optional(bool, true)
azure_migrate = optional(bool, true)
azure_monitor = optional(bool, true)
azure_openai_service = optional(bool, true)
azure_purview_account = optional(bool, true)
azure_purview_studio = optional(bool, true)
azure_relay_namespace = optional(bool, true)
Expand Down