Network gateway default parameters

[chrsundermann]

Overview/Summary

This is the Pull Request for the issue #924.

This PR fixes/adds/changes/removes

1. adds azurerm_virtual_network_gateway attribute, remote_vnet_traffic_enabled
2. adds azurerm_virtual_network_gateway attribute, virtual_wan_traffic_enabled

Breaking Changes

1. Attributes were implemented with >= 3.84.0 of the azurerm provider

Testing Evidence

Terraform plan before changes:

Terraform plan after changes shows "Nothing to change".

As part of this Pull Request I have

• Checked for duplicate Pull Requests
• Associated it with relevant issues, for tracking and closure.
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated relevant and associated documentation.

[chrsundermann]

@microsoft-github-policy-service agree

[matt-FFFFFF]

/azp run unit

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[matt-FFFFFF]

Hi @chrsundermann please can you run terraform fmt -recursive and commit the changes?

[chrsundermann]

Hi @chrsundermann please can you run terraform fmt -recursive and commit the changes?

Hi @matt-FFFFFF, I executed terraform fmt -recursive and pushed the changes.

[matt-FFFFFF]

/azp run unit

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[chrsundermann]

Hi @matt-FFFFFF,
do you have any updates on this cause I can't look into the AZ pipelines errors.

[matt-FFFFFF]

Minimum provider versions. Also there's a mapping missing as the data traverses through the module somewhere too

[matt-FFFFFF]

/azp run unit

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[matt-FFFFFF]

/azp run unit

[azure-pipelines]

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

[matt-FFFFFF]

Thanks for this - I've pulled into the ama branch for the next major release

[matt-FFFFFF]

@chrsundermann I had to add null values to the corresponding VPN gateway object in order for the values to be preserved when they are concat()

  azurerm_virtual_network_gateway_vpn = [
    for location, hub_network in local.hub_networks_by_location :
    {
      # ...
      remote_vnet_traffic_enabled = null
      virtual_wan_traffic_enabled = null

[chrsundermann]

Thanks for the update @matt-FFFFFF. Could only check with ExpressRoute setup. This was successfully deployed at customer site.

[matt-FFFFFF]

I don't think the attributes are valid for VPN but since all list members have to have same schema, needed to add as nulls.