-
Notifications
You must be signed in to change notification settings - Fork 443
Add supported algorithm tests #3296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds negative test cases for the 'alg' header claim to ensure proper rejection of insecure or invalid algorithm values like 'none' and 'noNe'. This helps prevent security regressions where these algorithms might be inadvertently accepted.
- Adds test cases for "none" and "noNe" algorithm values across all supported key types
- Ensures these insecure algorithms are properly rejected (expected result: false)
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
test/Microsoft.IdentityModel.Tokens.Tests/SupportedAlgorithmTests.cs
Outdated
Show resolved
Hide resolved
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
keegan-caruso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Description
This PR adds negative test cases for the 'alg' header claim to ensure proper rejection of insecure or invalid algorithm values like 'none' and 'noNe'. This helps prevent security regressions where these algorithms might be inadvertently accepted.
Adds test cases for "none" and "noNe" algorithm values across all supported key types
Ensures these insecure algorithms are properly rejected (expected result: false)