[Bug] ToJsonString does not serialize all fields of MSAL exception leading to data loss when deserialized

[crmann1]

Library version used

4.54

.NET version

.net framework 4.7 .net 6, net 8

Scenario

PublicClient - desktop app

Is this a new or an existing app?

The app is in production, and I have upgraded to a new version of MSAL

Issue description and reproduction steps

When the broker additional fields and telemetry fields were added the tojson and fromjson methods were not updated to include serializing the additional fields.

Relevant code snippets

MSAL Exception
    public string ToJsonString()
    public static MsalException FromJsonString(string json)

are missing
        public const string BrokerErrorContext = "BrokerErrorContext";
        public const string BrokerErrorTag = "BrokerErrorTag";
        public const string BrokerErrorStatus = "BrokerErrorStatus";
        public const string BrokerErrorCode = "BrokerErrorCode";
        public const string BrokerTelemetry = "BrokerTelemetry";

Expected behavior

Those fields should also be serialized.

Identity provider

Microsoft Entra ID (Work and School accounts and Personal Microsoft accounts)

Regression

No response

Solution and workarounds

No response

[bgavrilMS]

Hah, I always wondered if anybody actually uses ToJsonString / FromJsonString. I guess I know now :)

Are you serializing these so that you can store the exception in some DB?