Skip to content

Fall back to local cache if broker fails to return result for silent token call #4395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgavrilMS merged 3 commits into from
Nov 2, 2023
Merged

Fall back to local cache if broker fails to return result for silent token call #4395

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ab4294
Update SilentRequest.cs
ashok672 Oct 26, 2023
f5516aa
Merge branch 'main' into asram/fallback-local-cache-when-broker-silen…
ashok672 Nov 1, 2023
da07fe9
Fix failing unit tests
ashok672 Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/client/Microsoft.Identity.Client/Internal/Requests/Silent/SilentRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,20 +66,12 @@ protected override async Task<AuthenticationResult> ExecuteAsync(CancellationTok
_logger.Info("Broker is configured and enabled, attempting to use broker instead.");
var brokerResult = await _brokerStrategyLazy.Value.ExecuteAsync(cancellationToken).ConfigureAwait(false);

// fallback to local cache if broker fails
if (brokerResult != null)
{
_logger.Verbose(() => "Broker responded to silent request.");
return brokerResult;
}
else
{
_logger.Verbose(() => "Broker could not satisfy the silent request.");
throw new MsalUiRequiredException(
MsalError.FailedToAcquireTokenSilentlyFromBroker,
"Broker could not satisfy the silent request.",
null,
UiRequiredExceptionClassification.AcquireTokenSilentFailed);
}
}

_logger.Verbose(() => "Attempting to acquire token using local cache.");
Expand Down