Reworked retry policy functionality & Created IMDS retry policy #5231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Apr 14, 2025
bgavrilMS
reviewed
Apr 14, 2025
src/client/Microsoft.Identity.Client/Http/DefaultRetryPolicy.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Apr 23, 2025
src/client/Microsoft.Identity.Client/Http/DefaultRetryPolicy.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Apr 30, 2025
…yPolicy unit tests. Wrote UAMI unit tests for DefaultRetryPolicy.
…RetryPolicy tests.
This was referenced Aug 7, 2025
Closed
This was referenced Aug 18, 2025
Closed
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Sep 29, 2025
This was referenced Oct 24, 2025
Closed
Closed
This was referenced Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET's retry policy functionality now aligns with MSAL-Node. This PR was already implemented in MSAL-Node, here.
There are now two retry strategies:
LinearRetryStrategy and ExponentialRetryStrategy
There are now two retry policies, which use the retry strategies:
ImdsRetryPolicy and DefaultRetryPolicy (both ESTS and non-IMDS Managed Identity HttpManagers use DefaultRetryPolicy)
The unit tests in this PR are ported from the MSAL-Node PR:
All retry policy unit tests run "100 times faster" by overriding certain variables; Retry policy tests are no longer "expensive".