Authority validation todos #181
Conversation
| // todo: check for other authority types... | ||
| authorityType := "MSSTS" | ||
|
|
||
| var authorityType string |
There was a problem hiding this comment.
We do this in resolvers.go here
We delay doing this here because we want to avoid making a network call unless absolutely needed. So this code wont run while initializing app object here.
| err := c.Comm.JSONCall( | ||
| ctx, | ||
| endpoint, | ||
| // TODO(jdoak): not thrilled about this, because all calls should have this but |
There was a problem hiding this comment.
I think we add Correlation Id to all the calls that are part of a user flow for telemetry. I see thats what we do in MSAL Python. It was added here : AzureAD/microsoft-authentication-library-for-python#103
Could not find a spec though. @henrik-me thoughts ?
abhidnya13
requested review from
element-of-surprise,
henrik-me,
jhendrixMSFT and
keegan-caruso
apps/internal/oauth/resolvers.go
Outdated
| } | ||
|
|
||
| return resp.TenantDiscoveryEndpoint, nil | ||
| } else if authorityInfo.Tenant == "adfs" { |
There was a problem hiding this comment.
If you make this this first condition in the if block you can remove the != check that's currently on line 126.
…tion-library-for-go into authority_validation_todo
|
Kudos, SonarCloud Quality Gate passed!
|
Resolves #160