Skip to content

[msal-common] ADFS 2019 support #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sangonzal merged 9 commits into from
Jun 3, 2020
Merged

[msal-common] ADFS 2019 support #1617

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fada900
ADFS support
May 7, 2020
d0c280c
Update device code and scope set for ADFS
May 12, 2020
88d7cc8
Update test
May 12, 2020
4d67f98
Update comments
May 12, 2020
8c1a9a9
improving comments
May 12, 2020
65985ed
update browser and add documentation
May 15, 2020
4428b81
Merge branch 'dev' into sagonzal/msal-common-adfs
May 15, 2020
2bb4a78
Merge branch 'dev' into sagonzal/msal-common-adfs
Jun 2, 2020
2429e01
Merge branch 'dev' into sagonzal/msal-common-adfs
sangonzal Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comments
  • Loading branch information
Santiago Gonzalez committed May 12, 2020
commit 4d67f98b355357ba5b23a7b0d849470f21136822
3 changes: 1 addition & 2 deletions lib/msal-common/src/client/DeviceCodeClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,10 @@ export class DeviceCodeClient extends BaseClient {
const headers = this.createDefaultLibraryHeaders();

return this.executePostRequestToDeviceCodeEndpoint(this.defaultAuthority.deviceCodeEndpoint, queryString, headers);
// return this.executePostRequestToDeviceCodeEndpoint(`${this.defaultAuthority.canonicalAuthority}${Constants.DEVICE_CODE_ENDPOINT_PATH}`, queryString, headers);
}

/**
* Executes GET request to device code endpoint
* Executes POST request to device code endpoint
* @param deviceCodeEndpoint
* @param queryString
* @param headers
Expand Down