Skip to content

ADFS 2019 Support #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tnorling merged 28 commits into from
Aug 17, 2020
Merged

ADFS 2019 Support #1668

tnorling merged 28 commits into from
Aug 17, 2020

Conversation

@tnorling
Copy link
Collaborator

@tnorling tnorling commented May 15, 2020 •
edited
Loading

This PR ports the changes in #1617 to msal-core and builds on #1582 and will close #99

Differences from AAD/B2C Authorities:

  • ADFS does not return ClientInfo, this PR builds uid from the subject claim on idToken instead
  • ADFS does not return preferred_username, this PR sets this to upn instead
  • ADFS uses .well-known/openid-configuration instead of 2.0/.well-known/openid-configuration

@tnorling tnorling added the work-in-progress Issue or PR is not finished. label May 15, 2020
@jasonnutter jasonnutter mentioned this pull request May 27, 2020
Closed
@github-actions github-actions bot added angularjs msal-node Related to msal-node package samples Related to the samples apps for the library. labels May 27, 2020
@coveralls
Copy link

coveralls commented May 27, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 81.937% when pulling c08165c on msal-core-adfs into 44b8bc4 on dev.

@tnorling tnorling removed angularjs msal-node Related to msal-node package labels Jun 3, 2020
@tnorling tnorling added this to the [email protected] - Release milestone Jun 5, 2020
@jmckennon jmckennon mentioned this pull request Jun 10, 2020
Closed
@tnorling tnorling changed the title [msal-core] ADFS 2019 Support ADFS 2019 Support Jun 15, 2020
@github-actions github-actions bot added the msal-common Related to msal-common package label Jun 16, 2020
jmckennon
jmckennon approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@jmckennon jmckennon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

jasonnutter
jasonnutter approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick otherwise LGTM, good work!

@tnorling tnorling mentioned this pull request Jun 29, 2020
Closed
5 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2020

This PR has not seen activity in 14 days. It may be closed if it remains stale.

@github-actions github-actions bot added the no-pr-activity PR has been inactive for 14 days label Jul 7, 2020
@github-actions github-actions bot removed the no-pr-activity PR has been inactive for 14 days label Jul 8, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2020

This PR has not seen activity in 14 days. It may be closed if it remains stale.

@github-actions github-actions bot added the no-pr-activity PR has been inactive for 14 days label Jul 22, 2020
@github-actions github-actions bot removed the no-pr-activity PR has been inactive for 14 days label Jul 26, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2020

This PR has not seen activity in 14 days. It may be closed if it remains stale.

@github-actions github-actions bot added the no-pr-activity PR has been inactive for 14 days label Aug 9, 2020
@tnorling tnorling removed the no-pr-activity PR has been inactive for 14 days label Aug 11, 2020
@tnorling tnorling changed the base branch from dev to 1.4.0-release August 17, 2020 17:12
@tnorling tnorling merged commit 5f10555 into 1.4.0-release Aug 17, 2020
@tnorling tnorling mentioned this pull request Aug 24, 2020
Merged
@James-Randal
Copy link

James-Randal commented Sep 26, 2020

So is this resolved or not?

@tnorling
Copy link
Collaborator Author

tnorling commented Sep 28, 2020

@James-Randal ADFS 2019 is supported in [email protected]. If you have questions or find a bug please open a new issue. Thanks!

@tnorling tnorling deleted the msal-core-adfs branch October 19, 2020 19:56
@sglickman sglickman mentioned this pull request Dec 3, 2021
Closed
@youngj7 youngj7 mentioned this pull request Feb 20, 2022
Closed
8 tasks
@SelfishLucho SelfishLucho mentioned this pull request Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hectormmg hectormmg hectormmg approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo

@pkanher617 pkanher617 Awaiting requested review from pkanher617

@sameerag sameerag Awaiting requested review from sameerag

+2 more reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@jmckennon jmckennon jmckennon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

samples Related to the samples apps for the library.

Projects

None yet

Milestone

[email protected] - Release

Development

Successfully merging this pull request may close these issues.

ClientInfo not received in the response from AAD ADFS Support?

6 participants

@tnorling @coveralls @hectormmg @James-Randal @jasonnutter @jmckennon