[SSH] SSH support including ATs bound to keys #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This at least avoids the performance penalty in those implicit loops inside acquire_token_silent().
"Don't use spaces around the = sign when used to indicate a keyword argument" - quoted from https://www.python.org/dev/peps/pep-0008/#other-recommendations
rayluo
reviewed
Sep 27, 2019
Contributor
rayluo
left a comment
rayluo
left a comment
There was a problem hiding this comment.
Good job! Nice to have an e2e test case to ensure it works!
As discussed off-line, I leave only one comment below, and let's do the "pair programming" for the rest. :-)
rayluo
approved these changes
Sep 27, 2019
Contributor
rayluo
left a comment
rayluo
left a comment
There was a problem hiding this comment.
Thank Bogdan for an amazing pair-programming experience! Ship it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.