Skip to content

Conversation

@rayluo
Copy link
Contributor

@rayluo rayluo commented Oct 10, 2019

This will be useful in various web app scenarios.

This PR is currently marked as draft, only because it is temporarily using another pending PR as its base. I'll change the base, right after that other PR gets merged.

This PR is ready to be reviewed.

@rayluo rayluo requested a review from abhidnya13 October 10, 2019 22:24
@rayluo rayluo changed the base branch from customizable-response_type to dev October 15, 2019 21:50
@rayluo rayluo marked this pull request as ready for review October 15, 2019 21:50
Copy link
Contributor

@abhidnya13 abhidnya13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@rayluo rayluo force-pushed the support-prompt-parameter branch from 5f98405 to 05a195b Compare October 25, 2019 21:49
@rayluo rayluo merged commit 736da1c into dev Oct 25, 2019
@rayluo rayluo deleted the support-prompt-parameter branch October 25, 2019 21:52
@rayluo rayluo mentioned this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants