Skip to content

B2c implementation with policy parameter #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abhidnya13 wants to merge 9 commits into from
Closed

B2c implementation with policy parameter #110

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a3b2af8
Basic draft
abhidnya13 Oct 14, 2019
3d9e805
Merging recent changes
abhidnya13 Oct 15, 2019
605fe48
Adding policy as a separate parameter
abhidnya13 Oct 17, 2019
4837da6
Iterating
abhidnya13 Oct 17, 2019
4cf4311
Minor test changes
abhidnya13 Oct 18, 2019
1d1d8ac
Fixing tests and reverting instance discovery to return tenant discov…
abhidnya13 Oct 18, 2019
017d9d3
Fixing typo in parameter name
abhidnya13 Oct 18, 2019
997ece3
Updating B2C test cases to use new api
abhidnya13 Oct 18, 2019
2c26be5
Making changes on how userflow is passed to authority
abhidnya13 Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing typo in parameter name
  • Loading branch information
@abhidnya13
abhidnya13 committed Oct 18, 2019
commit 017d9d371cbd06ca94013ac9018848a33a240cc3
4 changes: 2 additions & 2 deletions msal/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def __init__(
client_credential=None, authority=None, validate_authority=True,
token_cache=None,
verify=True, proxies=None, timeout=None,
client_claims=None, trust_famework_policy=None):
client_claims=None, trust_framework_policy=None):
Copy link
Contributor

@rayluo rayluo Oct 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the currently proposal is:

.WithAuthority(string authority, string trustFrameworkPolicy)

not

.WithAuthority(string authority) .WithTrustFrameworkPolicy(string trustFrameworkPolicy)

So the precise mapping would be just change the "shape" of the existing authority parameter, rather than introducing a new parameter for PCA.

Perhaps we want to have something like this (with the comparing to C# version, side-by-side)?

authority = {"authority": "https://domain/tenant", "policy": "B2C_1_SignIn"}
# .WithAuthority(string authority, string trustFrameworkPolicy)

And then the pca can be created like this:

pca = PublicClientApplication(
    ...,
    authority={"authority": "https://domain/tenant", "policy": "B2C_1_SignIn"},
    ...)

Copy link
Contributor

@jennyf19 jennyf19 Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to use userFlow instead of policy or trustFrameworkPolicy. thanks.

Copy link
Contributor

@rayluo rayluo Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then let's use snake_case user_flow.

Copy link
Contributor Author

@abhidnya13 abhidnya13 Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"""Create an instance of application.

:param client_id: Your app has a client_id after you register it on AAD.
Expand Down Expand Up @@ -140,7 +140,7 @@ def __init__(
self.timeout = timeout
self.authority = Authority(
authority or "https://login.microsoftonline.com/common/",
validate_authority, verify=verify, proxies=proxies, timeout=timeout, trust_framework_policy=trust_famework_policy)
validate_authority, verify=verify, proxies=proxies, timeout=timeout, trust_framework_policy=trust_framework_policy)
# Here the self.authority is not the same type as authority in input
self.token_cache = token_cache or TokenCache()
self.client = self._build_client(client_credential, self.authority)
Expand Down
Binary file added sample/authorization-code-flow-sample/flask_session/5a76ff2437d33014f8dfc69482a5b9cd
View file
Open in desktop
Binary file not shown.