Skip to content

Conversation

@abhidnya13
Copy link
Contributor

No description provided.

@abhidnya13 abhidnya13 requested a review from rayluo October 22, 2019 00:19
Copy link

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really clean in coding style! Nice effort! We are very close. Just a couple minor things and we will be good to go!

PS: Please also backport this change into here. Did not realize it would behave differently on our tenant and on a new tenant.

Copy link
Contributor

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the efforts on this PR! Now we provide more guidance to customers!

@abhidnya13 abhidnya13 merged commit e71c791 into dev Oct 25, 2019
@rayluo rayluo deleted the update_samples branch October 25, 2019 21:41
@rayluo rayluo mentioned this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants