Skip to content

Conversation

@navyasric
Copy link
Contributor

@rayluo Please review. I wanted to add a badge for the CI build as well but couldn't find the CI build link for MSAL Python. Let me know as a comment if you have it.

@navyasric navyasric requested a review from rayluo November 13, 2019 00:44
Copy link

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

README.md Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to implement authentication flows => to acquire security tokens to call protected Web APIs ? Not sure if implementing auth flow is very customer focused?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Contributor

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. A minor comment below.

And this is the link to the build badge

Also the Doc badge Documentation Status

README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link https://aka.ms/aaddevsamplesv2 currently contains only 1 python sample (which is provided by Azure Function side, which is great). Do we plan on also adding our own web app sample, and all other so-called "dev samples" into there? Right now it feels like a rural area for Python. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I will take the next action item to update that doc with links to the Python samples.
Thanks

Copy link
Contributor

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚢

@navyasric navyasric merged commit 5ff6d83 into dev Nov 14, 2019
@navyasric navyasric deleted the nc-readme-update branch November 14, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants