-
Notifications
You must be signed in to change notification settings - Fork 207
Update Readme preview note and links #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jmprieur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to implement authentication flows => to acquire security tokens to call protected Web APIs ? Not sure if implementing auth flow is very customer focused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
284a06e to
cd9362a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. A minor comment below.
And this is the link to the build badge
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link https://aka.ms/aaddevsamplesv2 currently contains only 1 python sample (which is provided by Azure Function side, which is great). Do we plan on also adding our own web app sample, and all other so-called "dev samples" into there? Right now it feels like a rural area for Python. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I will take the next action item to update that doc with links to the Python samples.
Thanks
rayluo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🚢
cd9362a to
bd2930b
Compare
bd2930b to
f289d7d
Compare
@rayluo Please review. I wanted to add a badge for the CI build as well but couldn't find the CI build link for MSAL Python. Let me know as a comment if you have it.