Skip to content

Disable OBO tests due to a temporary test environment issue #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rayluo merged 1 commit into from
Nov 26, 2019
Merged

Disable OBO tests due to a temporary test environment issue #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/test_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ def test_adfs2019_fed_user(self):
password=self.get_lab_user_secret(config["lab"]["labname"]), **config)

@unittest.skipUnless(
os.getenv("OBO_CLIENT_SECRET"),
os.getenv("OBO_CLIENT_SECRET") and False, # Temporarily disable this case
"Need OBO_CLIENT_SECRET from https://buildautomation.vault.azure.net/secrets/IdentityDivisionDotNetOBOServiceSecret")
def test_acquire_token_obo(self):
# Some hardcoded, pre-defined settings
Expand All @@ -407,7 +407,9 @@ def test_acquire_token_obo(self):
scopes=[ # The OBO app's scope. Yours might be different.
"%s/access_as_user" % obo_client_id],
)
self.assertIsNotNone(pca_result.get("access_token"), "PCA should work")
self.assertIsNotNone(
pca_result.get("access_token"),
"PCA failed to get AT because %s" % json.dumps(pca_result, indent=2))

# 2. Our mid-tier service uses OBO to obtain a token for downstream service
cca = msal.ConfidentialClientApplication(
Expand Down