take openid as parameter #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayluo
reviewed
Feb 4, 2020
Contributor
rayluo
left a comment
rayluo
left a comment
There was a problem hiding this comment.
Thanks for this effort! :-)
Besides the actual comments in code below, let's also adjust a global thing. This code base uses the Git Flow to organize our branches and releases. So, our normal PRs would be merged back to dev branch, not master branch. In this particular case, though, it seems we are heading to have multiple small PRs down the road (which is great!), so perhaps we can create an async-feature branch and then all relevant smaller PRs would merge into such async-feature branch?
rayluo
approved these changes
Feb 4, 2020
Contributor
rayluo
left a comment
rayluo
left a comment
There was a problem hiding this comment.
Thanks for adjusting the PR. LGTM. You can merge it to async-feature at any time.
DharshanBJ
pushed a commit
that referenced
this pull request
Oct 4, 2024
Co-authored-by: Nathan Walsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds openid as a parameter to allow for async authorities later.
Idea for async authority: Async authority will have a
asyncclassmethodthat returns theopenid_configand then it will use the default initializer of this class to pass it in. When implementing the async version, logic will be shared between the sync/async for ifopenid_config is None