allow passing more parameters when generating auth uri #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Discussed with @nwalsh1995 offline. This PR was mainly created to bring support to Closing this PR here, and still thank @nwalsh1995 a lot for making this happen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are interested in adding some more parameters to the
get_authorization_request_url. Currently, it appears we can only send the parameters explicitly stated in theget_authorization_request_urlmethod, while there are more possible parameters than what is currently accepted.Since the
client.build_auth_request_urialready supportskwargs, we can pass kwargs to that function as well.