Cache lookup change (On Hold) #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abhidnya13
commented
Mar 27, 2019
abhidnya13
commented
- This PR corrects the cache look up logic which was case sensitive for 'target' field in the cache.
- It ensures that in scopes comparison when finding token cache User.Read and user.read is not differentiated.
- This change was found when testing Reading Authority Aliases #25 as scopes comparison would not return an Access Token and would then use Refresh token to acquire a new Access token.
henrik-me
reviewed
Mar 27, 2019
Contributor
|
Scope in OAuth2 is defined as case-sensitive. Better not relax this check from our implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.