Skip to content

Conversation

@rayluo
Copy link
Contributor

@rayluo rayluo commented Mar 29, 2019

This PR contains:

  • Refactor the cache test code, to provide build_response(...) helpers. They are helpful for the rest of this PR, and probably for all the recent and future PRs in unit testing.
  • The main FoCI behaviors are implemented in 2 files:
  • As a pre-existing behavior, the get_accounts() API does not filter account by client_id. This PR does not change that.
  • HIstorically we do not yet have a remove_account() API (there is actually an open github issue/feature request for that). We will tackle that task at a later time, after some internal discussion/clarification on that topic settles down. For now, this PR contains no remove_account().

@henrik-me
Copy link

remove_account() : You can still add this using the behavior known for now. Some details may change later but that is ok. tracking it as a separate item is ok, but it should be part of the API even if the internal behavior may change. This is still in preview.

Copy link

@henrik-me henrik-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@abhidnya13 abhidnya13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@rayluo rayluo merged commit 80f2397 into dev Mar 30, 2019
@rayluo rayluo added this to the Testing how milestone works milestone Apr 1, 2019
@abhidnya13 abhidnya13 mentioned this pull request Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants