Skip to content

Changing region endpoint, and remove usage of REGION_NAME env var #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rayluo merged 3 commits into from
Aug 10, 2021
Merged

Changing region endpoint, and remove usage of REGION_NAME env var #394

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71802d0
Change regional endpoint doname name
rayluo Aug 10, 2021
96140b0
Regional endpoint test cases do not rely on env var REGION_NAME
rayluo Aug 10, 2021
5fdae2d
REGION_NAME has no unified format across services
rayluo Aug 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
REGION_NAME has no unified format across services
  • Loading branch information
@rayluo
rayluo committed Aug 10, 2021
commit 5fdae2dd60dc41c30f92a6ce20c342ef51fddf04
9 changes: 2 additions & 7 deletions msal/region.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,9 @@


def _detect_region(http_client=None):
region = _detect_region_of_azure_function() # It is cheap, so we do it always
if http_client and not region:
if http_client:
return _detect_region_of_azure_vm(http_client) # It could hang for minutes
return region


def _detect_region_of_azure_function():
return os.environ.get("REGION_NAME")
return None


def _detect_region_of_azure_vm(http_client):
Expand Down