Skip to content

mbeliaev/fix_setup #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

mbeliaev/fix_setup #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
need to fix the version due to change in cryptography release. See py… 
…ca/cryptography#6344 and https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst
  • Loading branch information
Maksim Beliaev committed Sep 30, 2021
commit 98e93a6933bf050a2a57d8180e06fa4e14ccddeb
5 changes: 2 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,13 @@
'requests>=2.0.0,<3',
'PyJWT[crypto]>=1.0.0,<3',

'cryptography>=0.6,<4',
'cryptography>=0.6,<50',
Copy link

@graingert graingert Sep 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'cryptography>=0.6,<50',
'cryptography>=0.6',

The recommendation is to not set an upper bound:
pyca/cryptography#5532 (comment)

# load_pem_private_key() is available since 0.6
# https://github.com/pyca/cryptography/blob/master/CHANGELOG.rst#06---2014-09-29
#
# Not sure what should be used as an upper bound here
# https://github.com/pyca/cryptography/issues/5532
# We will go with "<4" for now, which is also what our another dependency,
# pyjwt, currently use.
# We will go with "<50" for now

"mock;python_version<'3.3'",
]
Expand Down