Exclude tests and add license file to pip package #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Actually thinking about it - we probably want to either exclude the tests module or move it inside the msal module as it currently gets installed as a top level module called "tests" which is probably not what we want. |
rayluo
reviewed
Jun 24, 2019
Contributor
rayluo
left a comment
rayluo
left a comment
There was a problem hiding this comment.
Thanks @roederja2 for contributing, again! :-)
Two quick comments below.
ghost
force-pushed
the
add_additional_files_to_package
branch
from
a0b00ea to
7d3cd05
Compare
ghost
changed the title
rayluo
approved these changes
Jun 25, 2019
Contributor
rayluo
left a comment
rayluo
left a comment
There was a problem hiding this comment.
Thanks @roederja2 ! Now Jann is a second time contributor! 2️⃣ :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the XML tests files so the tests can be run from a conda build