Skip to content

Conversation

@kit494way
Copy link
Contributor

  • This PR fixes the error that occurs in decoding token.
  • The ID token is encoded as base64url, not base64.
  • In the previous implementation, device_flow_sample.py will fails with error binascii.Error: Incorrect padding.

@rayluo
Copy link
Contributor

rayluo commented Aug 11, 2019

Konbanwa, Yasutaka san, thanks for the catch! We will look into the test failure caused by this PR on Python 2.7, before we can merge this in.

If you don't mind, can you also send your ID token to my email (which you can find here) so that I can test the issue and the fix by myself? This is totally optional, and we will still appreciate your help so far even without that test sample.

@rayluo rayluo merged commit d3735ad into AzureAD:dev Aug 13, 2019
@rayluo rayluo mentioned this pull request Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants