[SSH] Serialize AT token_type and expose in result #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bgavrilMS
commented
Sep 23, 2019
bgavrilMS
commented
- save token_type in AT payload in cache
- make sure authentication result exposes token_type from AT
bgavrilMS
commented
Sep 23, 2019
rayluo
requested changes
Sep 23, 2019
Contributor
rayluo
left a comment
rayluo
left a comment
There was a problem hiding this comment.
This PR is in good shape! 👍 Some comments here for some fine-tuning.
rayluo
approved these changes
Sep 23, 2019
Contributor
rayluo
left a comment
rayluo
left a comment
There was a problem hiding this comment.
"+4 -1" lines changed. What an efficient surgical strike! Ship it! 🚢
abhidnya13
approved these changes
Sep 23, 2019
Contributor
abhidnya13
left a comment
abhidnya13
left a comment
There was a problem hiding this comment.
Thanks @bgavrilMS for this. It looks good to me 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.