Bump MSAL to version 4.79.2 and handle changes to deprecated WithExtraQueryParameters APIs #3583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
approved these changes
Nov 5, 2025
neha-bhargava
approved these changes
Nov 6, 2025
Member
|
Pls update the title to say "bump MSAL to version xyz and update use of WithExtraQueryParameters" |
Avery-Dunn
changed the title
jmprieur
reviewed
Nov 11, 2025
Collaborator
jmprieur
left a comment
jmprieur
left a comment
There was a problem hiding this comment.
LGTM
I left a couple of comments
bgavrilMS
force-pushed
the
avdunn/extraqp-deprecation
branch
from
845ede5 to
a34377b
Compare
This reverts commit 7cce634.
…AD/microsoft-identity-web into avdunn/extraqp-deprecation
Avery-Dunn
changed the title
neha-bhargava
approved these changes
Nov 13, 2025
trwalke
approved these changes
Nov 14, 2025
jmprieur
approved these changes
Nov 17, 2025
Collaborator
jmprieur
left a comment
jmprieur
left a comment
There was a problem hiding this comment.
LGTM
Thanks @Avery-Dunn
This was referenced Dec 5, 2025
Merged
This was referenced Dec 12, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MSAL.NET the
WithExtraQueryParametersAPIs are receiving two changes: AzureAD/microsoft-authentication-library-for-dotnet#5536This PR updates to the latest MSAL.NET version and handles the new API and cache behavior. It does so by making changes to the
TokenAcquisitionclass, mainly by adjusting the existingMergeExtraQueryParametershelper method to return theDictionarystyle that the newWithExtraQueryParametersAPI expects.The changes were tested with a locally built version of MSAL.NET, and all existing tests that dealt with extra query parameters worked with minimal or no changes (in
TokenAcquisitionAuthorityTests,ExtraParametersTests,DownstreamApiOptionsMergeTests, andDownstreamApiEndpointTests)