-
Notifications
You must be signed in to change notification settings - Fork 2
Add k8s-extension troubleshoot phase 1: Infrastructure setup. #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Please fix the issues mentioned in the CI tests that are failing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements the first phase of troubleshooting infrastructure for the k8s-extension Azure CLI extension. The primary purpose is to establish foundational diagnostic capabilities for Kubernetes extensions by setting up the basic framework and essential utilities needed for troubleshooting operations.
Key changes include:
- Addition of diagnostic infrastructure with folder creation, logging utilities, and kubernetes connectivity validation
- Installation of required dependencies (kubernetes and oras libraries) for cluster interaction and container registry operations
- Implementation of a new
troubleshootcommand with initial parameter validation and basic checks
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Added kubernetes and oras dependencies required for cluster operations |
| utils.py | Added core utility functions for diagnostics including folder creation, timestamp generation, and kubernetes exception handling |
| custom.py | Implemented the main troubleshoot_extension function with helm/kubectl client installation and basic validation |
| consts.py | Added diagnostic constants for check states, fault types, and configuration values |
| commands.py | Registered the new troubleshoot command as a preview feature |
| _params.py | Added command-line parameters for the troubleshoot command |
| init.py | Added type hints for better code maintainability |
| k8s-custom-pipelines.yml | Updated Python version from 3.10 to 3.12 in CI pipeline |
3aeae81 to
1a52982
Compare
c66741d to
c586523
Compare
Work item:
https://msazure.visualstudio.com/One/_workitems/edit/34260596
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.