Skip to content

Conversation

@andborja
Copy link

@andborja andborja commented Aug 6, 2025

Work item:
https://msazure.visualstudio.com/One/_workitems/edit/34260596


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@github-actions
Copy link

github-actions bot commented Aug 6, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Aug 6, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@bavneetsingh16 bavneetsingh16 requested a review from Copilot August 6, 2025 16:19
@bavneetsingh16
Copy link

Please fix the issues mentioned in the CI tests that are failing:
https://dev.azure.com/ClusterConfigurationAgent/Extension%20CLI/_build/results?buildId=4154089&view=results

This comment was marked as outdated.

@andborja andborja requested a review from Copilot August 6, 2025 18:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the first phase of troubleshooting infrastructure for the k8s-extension Azure CLI extension. The primary purpose is to establish foundational diagnostic capabilities for Kubernetes extensions by setting up the basic framework and essential utilities needed for troubleshooting operations.

Key changes include:

  • Addition of diagnostic infrastructure with folder creation, logging utilities, and kubernetes connectivity validation
  • Installation of required dependencies (kubernetes and oras libraries) for cluster interaction and container registry operations
  • Implementation of a new troubleshoot command with initial parameter validation and basic checks

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
setup.py Added kubernetes and oras dependencies required for cluster operations
utils.py Added core utility functions for diagnostics including folder creation, timestamp generation, and kubernetes exception handling
custom.py Implemented the main troubleshoot_extension function with helm/kubectl client installation and basic validation
consts.py Added diagnostic constants for check states, fault types, and configuration values
commands.py Registered the new troubleshoot command as a preview feature
_params.py Added command-line parameters for the troubleshoot command
init.py Added type hints for better code maintainability
k8s-custom-pipelines.yml Updated Python version from 3.10 to 3.12 in CI pipeline

@andborja andborja force-pushed the andborja/33111202Phase1 branch from 3aeae81 to 1a52982 Compare August 20, 2025 11:51
@andborja andborja force-pushed the andborja/33111202Phase1 branch from c66741d to c586523 Compare August 20, 2025 12:26
@bavneetsingh16 bavneetsingh16 merged commit 1770640 into main Aug 22, 2025
5 of 9 checks passed
@bavneetsingh16 bavneetsingh16 deleted the andborja/33111202Phase1 branch August 22, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants