Lattice Helper: insert_element_every_ds#877
Merged
Merged
Conversation
ax3l
added
enhancement
ax3l
changed the title
insert_element_every_dsinsert_element_every_ds
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ax3l
force-pushed
the
topic-split-every-ds-helper
branch
2 times, most recently
from
March 10, 2025 17:29
015e28b to
d7ef26a
Compare
Add a helper to split a lattice every `ds` to insert another thin element, e.g., a BeamMonitor.
ax3l
changed the title
insert_element_every_dsinsert_element_every_ds
ax3l
force-pushed
the
topic-split-every-ds-helper
branch
from
March 17, 2025 18:55
d7ef26a to
15354bf
Compare
Member
Author
|
@cemitch99 I think we could merge this one and then cut the |
| s_next_insert += ds; | ||
| } | ||
| // case 2: current element ends exactly with next insert | ||
| else if (s_next_insert == cur_s_out) { |
Check notice
Code scanning / CodeQL
Equality test on floating-point values
Member
Author
There was a problem hiding this comment.
That is intentional to cover this corner case.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a helper to split a lattice every
dsto insert another thin element, e.g., a BeamMonitor.Close #537
Tasks
insert_elements(),insert(...),splice(...), ...?