Skip to content

Add platform interface #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvanbeusekom merged 6 commits into from
Mar 9, 2023
Merged

Add platform interface #34

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
818569a
Add platform interface
JeroenWeener Mar 8, 2023
bb15fd7
Update CHANGELOG.md
JeroenWeener Mar 9, 2023
f65dc71
Remove the default method channel implementation
JeroenWeener Mar 9, 2023
964a910
Fixes pubspec.yaml in example
JeroenWeener Mar 9, 2023
68b9ff3
Update CONTRIBUTING.md
JeroenWeener Mar 9, 2023
f2402b9
Copy `google_play_services_availability_test.dart`
JeroenWeener Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove the default method channel implementation
  • Loading branch information
@JeroenWeener
JeroenWeener committed Mar 9, 2023
commit f65dc71117b71600b47be281fe6b822ce36eec8d
16 changes: 8 additions & 8 deletions ...i_availability_platform_interface/lib/src/google_api_availability_platform_interface.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import 'package:google_api_availability_platform_interface/google_api_availability_platform_interface.dart';
import 'package:plugin_platform_interface/plugin_platform_interface.dart';

import 'implementations/method_channel_google_api_availability.dart';

/// The interface that implementations of `google_api_availability` must implement.
///
/// Platform implementations should extend this class rather than implement it
Expand All @@ -17,18 +15,20 @@ abstract class GoogleApiAvailabilityPlatform extends PlatformInterface {

static final Object _token = Object();

static GoogleApiAvailabilityPlatform _instance =
MethodChannelGoogleApiAvailability();
static GoogleApiAvailabilityPlatform? _instance;

/// The default instance of [GoogleApiAvailabilityPlatform] to use.
///
/// Defaults to [MethodChannelGoogleApiAvailability].
static GoogleApiAvailabilityPlatform get instance => _instance;
static GoogleApiAvailabilityPlatform? get instance => _instance;

/// Platform-specific plugins should set this with their own platform-specific
/// class that extends [GoogleApiAvailabilityPlatform] when they register
/// themselves.
static set instance(GoogleApiAvailabilityPlatform instance) {
static set instance(GoogleApiAvailabilityPlatform? instance) {
if (instance == null) {
throw AssertionError(
'Platform interfaces can only be set to a non-null instance');
}

PlatformInterface.verify(instance, _token);
_instance = instance;
}
Expand Down
77 changes: 0 additions & 77 deletions ...ty_platform_interface/lib/src/implementations/method_channel_google_api_availability.dart
View file
Open in desktop

This file was deleted.

6 changes: 2 additions & 4 deletions ...availability_platform_interface/test/google_api_availability_platform_interface_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,15 @@

import 'package:flutter_test/flutter_test.dart';
import 'package:google_api_availability_platform_interface/google_api_availability_platform_interface.dart';
import 'package:google_api_availability_platform_interface/src/implementations/method_channel_google_api_availability.dart';
import 'package:plugin_platform_interface/plugin_platform_interface.dart';
import 'package:mockito/mockito.dart';

void main() {
TestWidgetsFlutterBinding.ensureInitialized();

group('$GoogleApiAvailabilityPlatform', () {
test('$MethodChannelGoogleApiAvailability is the default instance', () {
expect(GoogleApiAvailabilityPlatform.instance,
isA<MethodChannelGoogleApiAvailability>());
test('The default instance is null', () {
expect(GoogleApiAvailabilityPlatform.instance, isNull);
});

test('Cannot be implemented with `implements`', () {
Expand Down