Re-add platform interface #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvanbeusekom
approved these changes
Mar 9, 2023
Member
mvanbeusekom
left a comment
mvanbeusekom
left a comment
There was a problem hiding this comment.
LGTM, modules one small improvement regarding the analysis_options.yaml file.
| @@ -0,0 +1,10 @@ | |||
| include: package:flutter_lints/flutter.yaml | |||
Member
There was a problem hiding this comment.
If we put this file in the root of the repository it will be reused by all packages. That way we only have to maintain one file.
Can you move this to the root folder and also remove the google_availability_api/analysis_options.yaml file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
This is a revert of reverted PR #34.
This PR adds a platform interface for the plugin. This interface is part of the ongoing effort to refactor the code to use the federated plugin architecture. The
GooglePlayServicesAvailabilitymodel has been copied over, and its original version will be removed in a later PR.The plugin uses a non-federated architecture.
🆕 What is the new behavior (if this is a feature change)?
The plugin will function the same. The platform interface code is contained in the new directory
/google-api-availability-platform-interfaceand is not used outside of it.💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
This PR adds tests for the newly added
GoogleApiAvailabilityPlatform. These tests can be found ingoogle-api-availability-platform-interface/test/google_api_availability_platform_interface_test.dart.📝 Links to relevant issues/docs
This PR is part of the ongoing effort to refactor this plugin to use the federated architecture requested in #33.
🤔 Checklist before submitting