Extract Android implementation to separate folder #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r/flutter-google-api-availability into enhancement/platform-android
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 93.93% 92.85% -1.09%
==========================================
Files 2 1 -1
Lines 33 28 -5
==========================================
- Hits 31 26 -5
Misses 2 2
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the reference to
google_api_platform_interfaceingoogle_api_platform_interface_android/pubspec.yamlis not resolving becausegoogle_api_platform_interfacehas not yet been published to pub.dev.✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
The Android implementation has been extracted to a plugin implementation, following the federated plugin architecture.
The 'old' Android code is still there, and remains in use. Once the federated structure is in place we can remove the 'old' Android code and switch over to the new code.
💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
Dart tests for the Android platform have been updated.
📝 Links to relevant issues/docs
This PR is part of #33.
🤔 Checklist before submitting