Allow removal of platform instance for testing purposes #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// This method is exposed for testing purposes only and should not be used by | ||
| /// clients of the plugin. | ||
| @visibleForTesting | ||
| static removeInstance() => _instance = null; |
Member
There was a problem hiding this comment.
Is there a specific use case for this?
I have not seen it in any of the other plugins and from the top of my head I cannot really think of a specific case where this is needed. Would like to hear if there is one.
Contributor
Author
There was a problem hiding this comment.
It is included so we can test whether the methods that are exposed to users of the plugin correctly throw if no platform is registered. This way we can emulate the scenario where the app runs on an unsupported platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Adds method to platform interface to remove the registered instance. This is useful for tests where a test needs to check the behavior of a non-existing instance.
There is no way to set the instance to null, as there is a specific check to prevent users from doing that.
🆕 What is the new behavior (if this is a feature change)?
Using
removeInstance, tests can unregistered a previously registered instance of the platform interface.💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
📝 Links to relevant issues/docs
This PR is part of #33.
🤔 Checklist before submitting