Improve Message Reception Reliability in RosTopicSubNode::tick() #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the message handling logic in the
RosTopicSubNode<T>::tick()method to ensure that messages are received within a short timeout period before proceeding. The main change introduces a 50ms timeout loop that spins the callback group executor and waits for a message, improving reliability when messages may not have arrived yet.Message reception and processing improvements:
RosTopicSubNode<T>::tick()to spin the callback group executor and wait for a message iflast_msg_is not available, sleeping briefly between spins to avoid busy waiting.