Skip to content

Conversation

@Manouchehri
Copy link
Contributor

Resolve #5632. Should be covered by existing unit tests.

Tested locally using 2024-09-01-preview, but should also work with 2024-08-01-preview too.

@vercel
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 8:49pm

@krrishdholakia
Copy link
Contributor

Hey @Manouchehri

Should be covered by existing unit tests.

Which test do you believe covers this scenario?

@krrishdholakia
Copy link
Contributor

2024-09-01-preview

Oh - is this supported across all models?

@krrishdholakia
Copy link
Contributor

If you can share a screenshot of this working as expected, that should be good enough to merge to a dev branch for testing

@Manouchehri
Copy link
Contributor Author

Yes, supported on all models.

@Manouchehri
Copy link
Contributor Author

image

@krrishdholakia krrishdholakia changed the base branch from main to litellm_stable_prs October 3, 2024 01:43
@krrishdholakia krrishdholakia merged commit c62af0d into BerriAI:litellm_stable_prs Oct 3, 2024
krrishdholakia added a commit that referenced this pull request Oct 3, 2024
* (azure): Enable stream_options for Azure OpenAI. (#6024)

* LiteLLM Minor Fixes & Improvements (10/02/2024)  (#6023)

* feat(together_ai/completion): handle together ai completion calls

* fix: handle list of int / list of list of int for text completion calls

* fix(utils.py): check if base model in bedrock converse model list

Fixes #6003

* test(test_optional_params.py): add unit tests for bedrock optional param mapping

Fixes #6003

* feat(utils.py): enable passing dummy tool call for anthropic/bedrock calls if tool_use blocks exist

Fixes #5388

* fixed an issue with tool use of claude models with anthropic and bedrock (#6013)

* fix(utils.py): handle empty schema for anthropic/bedrock

Fixes #6012

* fix: fix linting errors

* fix: fix linting errors

* fix: fix linting errors

* fix(proxy_cli.py): fix import route for app + health checks path (#6026)

* (testing): Enable testing us.anthropic.claude-3-haiku-20240307-v1:0. (#6018)

* fix(proxy_cli.py): fix import route for app + health checks gettsburg.wav

Fixes #5999

---------

Co-authored-by: David Manouchehri <[email protected]>

---------

Co-authored-by: Ved Patwardhan <[email protected]>
Co-authored-by: David Manouchehri <[email protected]>

---------

Co-authored-by: David Manouchehri <[email protected]>
Co-authored-by: Ved Patwardhan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Always send "stream_options": {"include_usage": true} when "stream": true

2 participants