Skip to content

Fixing issue TypeError #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: v13.0.17
Choose a base branch
from
Open

Fixing issue TypeError #255

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c4b88aa
Removed parameter IncludeLinkedAccountIds from GetUser call
pturegano Aug 5, 2022
491fbcb
Removed parameter IncludeLinkedAccountIds from GetUser call
pturegano Aug 5, 2022
6f22c1e
Updated to supported version urllib3
pturegano Aug 5, 2022
7d9e3fa
Merge pull request #246 from BingAds/v13.0.16
xinyuwen2 Jun 7, 2023
373a586
Merge pull request #215 from pturegano/example_urllib3Update
qitia Jul 10, 2023
d1ca68e
Merge pull request #252 from BingAds/v13.0.17
xinyuwen2 Sep 4, 2023
2c905f4
Fixed bid_suggestion_data.py. Implemented abstract methods in BulkKey…
MrOllzzor Oct 6, 2023
43a1ae1
Added support for all fields in BulkKeywordBestPositionBid, BulkKeywo…
MrOllzzor Oct 9, 2023
b8fc58b
Added support for all fields in BulkKeywordBestPositionBid, BulkKeywo…
MrOllzzor Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added support for all fields in BulkKeywordBestPositionBid, BulkKeywo… 
…rdFirstPageBid and BulkKeywordMainLineBid.
  • Loading branch information
@MrOllzzor
MrOllzzor committed Oct 9, 2023
commit b8fc58b7a46b159a7d27380df2a5fd0de6e8acdf
18 changes: 9 additions & 9 deletions bingads/v13/bulk/entities/bid_suggestion_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,12 +271,12 @@ def read_from_row_values(self, row_values):
_SimpleBulkMapping(
header=_StringTable.Impressions,
field_to_csv=lambda c: bulk_str(c.impressions),
csv_to_field=lambda c, v: setattr(c, '_impressions', float(v) if v else None)
csv_to_field=lambda c, v: setattr(c, '_impressions', int(v) if v else None)
),
_SimpleBulkMapping(
header=_StringTable.Clicks,
field_to_csv=lambda c: bulk_str(c.clicks),
csv_to_field=lambda c, v: setattr(c, '_clicks', float(v) if v else None)
csv_to_field=lambda c, v: setattr(c, '_clicks', int(v) if v else None)
),
_SimpleBulkMapping(
header=_StringTable.CTR,
Expand All @@ -301,7 +301,7 @@ def read_from_row_values(self, row_values):
_SimpleBulkMapping(
header=_StringTable.Conversions,
field_to_csv=lambda c: bulk_str(c.conversions),
csv_to_field=lambda c, v: setattr(c, '_conversions', float(v) if v else None)
csv_to_field=lambda c, v: setattr(c, '_conversions', int(v) if v else None)
),
_SimpleBulkMapping(
header=_StringTable.CPA,
Expand Down Expand Up @@ -456,12 +456,12 @@ def read_from_row_values(self, row_values):
_SimpleBulkMapping(
header=_StringTable.Impressions,
field_to_csv=lambda c: bulk_str(c.impressions),
csv_to_field=lambda c, v: setattr(c, '_impressions', float(v) if v else None)
csv_to_field=lambda c, v: setattr(c, '_impressions', int(v) if v else None)
),
_SimpleBulkMapping(
header=_StringTable.Clicks,
field_to_csv=lambda c: bulk_str(c.clicks),
csv_to_field=lambda c, v: setattr(c, '_clicks', float(v) if v else None)
csv_to_field=lambda c, v: setattr(c, '_clicks', int(v) if v else None)
),
_SimpleBulkMapping(
header=_StringTable.CTR,
Expand All @@ -486,7 +486,7 @@ def read_from_row_values(self, row_values):
_SimpleBulkMapping(
header=_StringTable.Conversions,
field_to_csv=lambda c: bulk_str(c.conversions),
csv_to_field=lambda c, v: setattr(c, '_conversions', float(v) if v else None)
csv_to_field=lambda c, v: setattr(c, '_conversions', int(v) if v else None)
),
_SimpleBulkMapping(
header=_StringTable.CPA,
Expand Down Expand Up @@ -641,12 +641,12 @@ def read_from_row_values(self, row_values):
_SimpleBulkMapping(
header=_StringTable.Impressions,
field_to_csv=lambda c: bulk_str(c.impressions),
csv_to_field=lambda c, v: setattr(c, '_impressions', float(v) if v else None)
csv_to_field=lambda c, v: setattr(c, '_impressions', int(v) if v else None)
),
_SimpleBulkMapping(
header=_StringTable.Clicks,
field_to_csv=lambda c: bulk_str(c.clicks),
csv_to_field=lambda c, v: setattr(c, '_clicks', float(v) if v else None)
csv_to_field=lambda c, v: setattr(c, '_clicks', int(v) if v else None)
),
_SimpleBulkMapping(
header=_StringTable.CTR,
Expand All @@ -671,7 +671,7 @@ def read_from_row_values(self, row_values):
_SimpleBulkMapping(
header=_StringTable.Conversions,
field_to_csv=lambda c: bulk_str(c.conversions),
csv_to_field=lambda c, v: setattr(c, '_conversions', float(v) if v else None)
csv_to_field=lambda c, v: setattr(c, '_conversions', int(v) if v else None)
),
_SimpleBulkMapping(
header=_StringTable.CPA,
Expand Down