feat: implement isWalletAddress for mpc eddsa coins #7292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavjain97
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pranavjain97
force-pushed
the
WP-6378-isWalletAddress-coins
branch
from
49214eb to
d971ec0
Compare
pranavjain97
force-pushed
the
WP-6378-isWalletAddress-coins
branch
from
d971ec0 to
e9982fe
Compare
dpkjnr
previously approved these changes
Oct 22, 2025
zahin-mohammad
previously approved these changes
Oct 22, 2025
| throw new InvalidAddressError(`invalid address: ${address}`); | ||
| } | ||
|
|
||
| if (!keychains || keychains.length === 0) { |
There was a problem hiding this comment.
Suggested change
| if (!keychains || keychains.length === 0) { | |
| if (!keychains?.length) { |
Comment on lines
160
to
162
| keychains: { | ||
| commonKeychain: string; | ||
| }[]; |
There was a problem hiding this comment.
Can you define a type for this instead of in-lining it.
There was a problem hiding this comment.
nvm; replaced with Keychains
| * @throws {InvalidAddressError} if the address is invalid | ||
| * @throws {Error} if required parameters are missing or invalid | ||
| */ | ||
| export async function verifyEddsaTssWalletAddress( |
There was a problem hiding this comment.
We should have coin agnostic tests for this.
pranavjain97
dismissed stale reviews from zahin-mohammad and dpkjnr
via
9513595
pranavjain97
requested review from
dpkjnr,
mtexeira-simtlix and
zahin-mohammad
pranavjain97
force-pushed
the
WP-6378-isWalletAddress-coins
branch
from
9513595 to
a64baf3
Compare
mtexeira-simtlix
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WP-6378