fix: support BlockStatement arrow functions in codec parser #1061
+75
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only implicit-return arrow functions were supported:
```typescript
const factory = () => t.string; // ✅ Worked
BlockStatement arrow functions with explicit returns would fail:
const factory = () => {
return t.string; // ❌ Error: "BlockStatement arrow functions are not yet supported"
};
```
This fix:
- Searches BlockStatement.stmts for ReturnStatement nodes
- Extracts the return value expression (returnStmt.argument)
- Passes it to parseCodecInitializer() for recursive parsing
- Validates that a return statement exists with a non-undefined argument
Both styles now produce identical schemas since they converge on the
same parseCodecInitializer() call with the return value expression.
Test case added using BooleanFromNullableWithFallback() with explicit
block syntax to verify the parser handles both arrow function styles.
yanxue-22
deleted the
DX-2182-openapi-generator-failing-to-parse-utils
branch
|
🎉 This PR is included in version @api-ts/[email protected] 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, only implicit-return arrow functions were supported. However, BlockStatement arrow functions are not yet supported.
Example
Fix:
BlockStatement.stmtsfor ReturnStatement nodesreturnStmt.argument)parseCodecInitializer()for recursive parsingBoth (block statement and non-block statement) styles now produce identical schemas since they converge on the same
parseCodecInitializer()call with the return value expression.Test case added using
BooleanFromNullableWithFallback()with explicit block syntax to verify the parser handles both arrow function styles.