This repository was archived by the owner on Jan 25, 2024. It is now read-only.
Update Zcash tesnet branch id #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyquinn
reviewed
Aug 27, 2019
| 3: 0x5ba81b19, | ||
| 4: 0x76b809bb | ||
| // 4: 0x76b809bb (old Sapling branch id) | ||
| 4: 0x2bb40e60 |
There was a problem hiding this comment.
Why does the old sapling branch id get commented out in favor of blossom? Why doesn't sapling stay as branch id 4 and blossom become branch id 5?
There was a problem hiding this comment.
The enum id (4) is actually the transaction id. This one is changed every time the transaction struct changes. Last time it happened was when Sapling was introduced. For Blossom, the struct is the same, but the branch id was updated to 0x2bb40e60 https://github.com/zcash/zips/blob/master/zip-0205.rst#specification
paddyquinn
approved these changes
Aug 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Zcash branch id due to Blossom network upgrade in testnet following https://github.com/zcash/zips/blob/master/zip-0206.rst#specification