This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Fix pdata calculation #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iomaganaris
added
frontiers-paper-2021
bug
netpyne
Codecov Report
@@ Coverage Diff @@
## master #775 +/- ##
=======================================
Coverage 56.00% 56.00%
=======================================
Files 108 108
Lines 8994 8994
=======================================
Hits 5037 5037
Misses 3957 3957
Continue to review full report at Codecov.
|
Collaborator
Collaborator
pramodk
reviewed
Feb 22, 2022
pramodk
approved these changes
Feb 22, 2022
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
* Read iontype for every instance because it might be different for different instances CoreNEURON Repo SHA: BlueBrain/CoreNeuron@43e881e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Different sections might have different
iontypes as for example in the M1 NetPyNE simulation. Instead of reading only theiontypeof the first section of each mechanism, calculate each one based on itsiontype.How to test this?
I was able to reproduce this issue only with the M1 simulation and when setting
cfg.singleCellPops = 1.This option
Creates pops with 1 single cell (to debug)according to the documentation.Using this branch I managed to get the same spikes between CoreNEURON and NEURON on CPU with
debugbuilds enabled and using direct mode.With this PR M1 and S1 simulations (reduced versions with
cfg.singleCellPops = 1) generate the same spikes in CPU with debug and release builds on offline and online CoreNEURON execution.Related neuron part https://github.com/neuronsimulator/nrn/blob/9624c96e17b6b676245582f66f83c64f11876368/src/nrnoc/eion.cpp#L356
M1 and S1 results validation from the large sims with the full circuit are WIP.