This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Make legacy scopmath solvers header only, drop kinderiv.py and dimplic.cpp #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
It seems like the simulation stack is failing with unrelated errors and could be ignored.
|
pramodk
reviewed
May 4, 2022
Collaborator
pramodk
left a comment
pramodk
left a comment
There was a problem hiding this comment.
Quickly skimmed through this and overall everything looks fine!
olupton
commented
May 5, 2022
olupton
force-pushed
the
olupton/scopmath-inline
branch
from
8c42d35 to
d534166
Compare
This comment was marked as outdated.
This comment was marked as outdated.
pramodk
reviewed
May 12, 2022
Collaborator
pramodk
left a comment
pramodk
left a comment
There was a problem hiding this comment.
1-2 minor comments but overall LGTM!
Collaborator
olupton
added a commit
to BlueBrain/mod2c
that referenced
this pull request
May 12, 2022
* Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809.
olupton
added a commit
to BlueBrain/nmodl
that referenced
this pull request
May 12, 2022
* Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809. * Add fmt_line, fmt_start_block and restart_block methods to CodePrinter. * gitlab-ci: support CVF_BRANCH variable.
olupton
force-pushed
the
olupton/scopmath-inline
branch
from
ee2d196 to
2f8b46d
Compare
Collaborator
iomaganaris
pushed a commit
to BlueBrain/nmodl
that referenced
this pull request
May 13, 2022
* Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809. * Add fmt_line, fmt_start_block and restart_block methods to CodePrinter. * gitlab-ci: support CVF_BRANCH variable.
iomaganaris
pushed a commit
to BlueBrain/nmodl
that referenced
this pull request
May 13, 2022
* Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809. * Add fmt_line, fmt_start_block and restart_block methods to CodePrinter. * gitlab-ci: support CVF_BRANCH variable.
iomaganaris
pushed a commit
to BlueBrain/nmodl
that referenced
this pull request
May 13, 2022
* Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809. * Add fmt_line, fmt_start_block and restart_block methods to CodePrinter. * gitlab-ci: support CVF_BRANCH variable.
iomaganaris
pushed a commit
to BlueBrain/nmodl
that referenced
this pull request
May 13, 2022
* Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809. * Add fmt_line, fmt_start_block and restart_block methods to CodePrinter. * gitlab-ci: support CVF_BRANCH variable.
iomaganaris
added a commit
to BlueBrain/nmodl
that referenced
this pull request
May 17, 2022
#868) * Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809. * Add fmt_line, fmt_start_block and restart_block methods to CodePrinter. * gitlab-ci: support CVF_BRANCH variable. Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
iomaganaris
added a commit
to BlueBrain/nmodl
that referenced
this pull request
Sep 15, 2022
#868) * Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809. * Add fmt_line, fmt_start_block and restart_block methods to CodePrinter. * gitlab-ci: support CVF_BRANCH variable. Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
iomaganaris
added a commit
to BlueBrain/nmodl
that referenced
this pull request
Sep 15, 2022
#868) * Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809. * Add fmt_line, fmt_start_block and restart_block methods to CodePrinter. * gitlab-ci: support CVF_BRANCH variable. Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
…c.cpp (BlueBrain/CoreNeuron#809) * Solvers used for derivimplicit, sparse and euler methods were compiled as a separate library. These solvers were called from generated .mod to .cpp files. * But as GPU programming models don't support function pointers, we use a very convoluted way via macros (+ _kinderiv.py) to achieve similar functionality as function pointers. This also needed to use `acc routine seq` for all the solver routines. But this is not compatible when we want to support shared libraries for python wheels (see BlueBrain/CoreNeuron#141) * With this PR we make all solvers inline-able by making them part of headers * Finally drop kinderiv.py ! * Drop acc routine seq * Reallocate net receive buffers using ecalloc_align/free_memory for consistency. * fix-up test, update submodules * Make the NetReceiveBuffer initial size at least 8. CoreNEURON Repo SHA: BlueBrain/CoreNeuron@554c250
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move scopmath solvers into header files, drop kinderiv.py/dimplic.cpp workarounds.
TODO:
Use certain branches in CI pipelines.
CI_BRANCHES:NEURON_BRANCH=master,NMODL_BRANCH=master,SPACK_BRANCH=develop